Qc-meg #30
Qc-meg #30
Conversation
|
Hi @Urszula11 , you've asked @oscfer88 to review this. Are you specifically waiting for him to check / add something or is this ready to merge already? Thanks. |
|
@pravsripad Yes, I am waiting for him to ensure my part is compatible with the rest of MEEG code |
|
@Urszula11 @pravsripad Sorry, I missed this. |
|
@oscfer88 I meant only the QC code, overall, nothing specific |
There was a problem hiding this comment.
@Urszula11 there are a couple of minor things I mentioned above that you would like to check. the rest looks good to me.
There was a problem hiding this comment.
I guess this script can be removed given that we are already provide the BIDS converted data @Urszula11 ?
coglib/meeg/qc/QC_epochs.py
Outdated
|
|
||
| # Plot percentage of rejected epochs per channel | ||
| #fig1 = epochs.plot_drop_log() | ||
| #pdf.savefig(fig1) | ||
| plt.close() |
There was a problem hiding this comment.
not sure whether line 192 ( plt.close() ) should be removed or not
There was a problem hiding this comment.
sorry, I didn't notice that this file was deleted in a following commit. Ignore this comment @Urszula11
|
Hi @oscfer88 @Urszula11 , please check this out to see if we can merge and close the changes here. |
Updating qc to more basic version. Running the code needs to be discussed still as diffrent than MEG team!