CU-869574kvp update snomed preprocessing naming #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might need some additions:
|
Separate extensions into an Enum. Do the release/paths check at init to allow for early failures in case of issues
Move common avoids to a common location. Fix UK Drug relationship name
Remove some clutter by separating common prefixes for release types and file names.
Remove some clutter by separating common suffixes for release types.
New abstraction. Use supprted extensions which describe their file formats along with bundles which give some further insight and control.
For AU models, the folder name seems to be 'SnomedCT_Release_AU1000036_20240630T120000Z', so the 1st part is just 'Release' and the 2nd part is indicative of AU. Add usage of this where relevant.
Add patch for files/folders where applicable. Change the paths of attributes where applicable.
|
PS: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #467
Using a regular expression to capture the release from the folder name.
Upon init, this check is non-strict (i.e no exception is raised if release is unable to be found) since it could refer to a parent folder.
When parsing through the subfolder, the check is string (i.e an exception is raised if no release is found) since those are expected to be Snomed release folders (with
SnomedCTin the names).Added some relevant tests for working and failing folder names. Both just the base names as well as longer paths. For both strict and non-strict mode.