Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for pinch in/out gestures #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oryasida
Copy link
Contributor

Initial support for pinch in/out gestures. libinput does differentiate between 2/3/4 fingers pinch events so adding support for all the different variations can be done, but reliably executing the different variants isn't really easy.

@Coffee2CodeNL
Copy link
Owner

I was actually holding off on this one because pinch events aren't reliably picked up by libinput yet and I wanted to look if I could implement pinch/rotate events on my own via raw input, for this I'm communicating with the libinput maintainers

@oryasida
Copy link
Contributor Author

I did notice that pinch events are a little iffy sometimes. Also played around with the rotate events pinch gestures, and noticed that the libinput_event_gesture_get_angle_delta function would sometimes return a high value if you just place to fingers and wiggle them a little (without really changing the angle between them), so doing something like volume control (when you don't wait for the fingers to lift of the pad - before receiving the end event) doesn't work nicely.

@yigitsever yigitsever mentioned this pull request Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants