Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

credits? #5

Open
shiffman opened this issue Sep 25, 2017 · 3 comments
Open

credits? #5

shiffman opened this issue Sep 25, 2017 · 3 comments

Comments

@shiffman
Copy link
Member

shiffman commented Sep 25, 2017 •
edited
Loading

While this is ultimately a collaborative, community open source project, I'd like to be thoughtful and generous in crediting coders who contributed. Maybe a list of github usernames for each clock in the README? Or should we rely on the fact that github the tool itself ultimately tracks this?
@Merijn-DH
Copy link
Contributor

I think this is a good enough credit to the contributors (which is also a link in the index.html file): https://github.com/CodingTrain/12oclocks/graphs/contributors

but it's open for debate..

@meiamsome
Copy link
Member

I am intending to allow clicking on a clock to open it to fill more of the screen, and was thinking it'd be nice to list contributors there.

Merijn-DH added a commit to Merijn-DH/12oclocks that referenced this issue Sep 25, 2017
@Merijn-DH
Updated clock CodingTrain#5 with exact measurements
8c38849 
Got the exact size measurements, relative to the screen size for scaling, from the original version. I also noticed the minutes' and seconds' angles are relative to that of the hours, but reversed.
Merijn-DH added a commit to Merijn-DH/12oclocks that referenced this issue Sep 25, 2017
@Merijn-DH
Updated clock CodingTrain#5 with exact measurements
30625c3 
Got the exact size measurements, relative to the screen size for scaling, from the original version. I also noticed the minutes' and seconds' angles are relative to that of the hours, but reversed.
@meiamsome meiamsome mentioned this issue Sep 27, 2017
Merged
Merijn-DH added a commit to Merijn-DH/12oclocks that referenced this issue Oct 1, 2017
@Merijn-DH
Clock CodingTrain#5 - Fixed spaces between rectangels
d225d86 
I am checking if there is a rectangle to the right or bottom and increasing the width or height by 1 to 'connect' them. It is a somewhat ugly solution since it is now always drawing every rectangle twice (to prevent an extra 1 by 1 rectangle when both height and width are increased on the same rectangle). Maybe it would be better to draw an extra 1 by 'size' rectangle at the bottom and/or right?
@Merijn-DH Merijn-DH mentioned this issue Oct 1, 2017
Closed
@meiamsome
Copy link
Member

I just pushed an update that adds attribution at the clock level - check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shiffman @meiamsome @Merijn-DH