-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visible spaces between squares #22
Comments
I have the same issue with clock 3 using arcs. Did not find any reliable workaround. |
noSmooth() can be used to disable anti-aliasing, but I tried doing adding this to the clock you mentioned but it had no effect. |
One way you can fix this is to enlarge all of the shapes so that they actually overlap by a small amount so there's no possible gap to show through. The edges all line up nicely still but the corners will look a bit problematic. I guess it'll be a middleground between looking bad one way or another, if there's not a better fix. You could also look at working out maximal rectangles you can draw to avoid this... |
See my solution for clock 5 in my pull request (#36). |
Anyone want to implement this for the final couple of clocks with these issues (8, 12 and probably 7)? |
Sure, as soon as I have time! |
Sounds good, I just pushed in changes that let you view singular clocks, so it should be easier to check the clocks now (Click to enlarge) |
I fixed 7 and 8. Clock 12 looks good in my browser.. maybe it is different for others?! |
You're right, I can see in my browser as well. Since it's 2 am for me I'll fix it tomorrow unless someone else would be so kind to look into it :) |
I might have a solution to this problem though I'm not sure if you'll like it or not.
to draw the character gapless. |
@waielal I had the same idea - but hadn't got around to implementing it - it should be great for the final clock, and maybe retrofitting some of the others if it's so desired, My idea was to just have the font defined as a function for each of the characters: font2 = {
...
"3": function(sketch) {
// beginShape, vertex, endShape etc.
}
...
} And then use transformations and style changes to position it correctly. It's certainly workable, and would love seeing your take on it |
I think that's all of them - or does 10 need fixing too? |
10 also has some gaps. But less noticable than the others. |
Example:
Issue:
This affects all clocks whose numbers are drawn using squares (rect).
We're getting visible spaces between squares which are drawn side by side. The source examples have clean flat rectangles, so it would be nice to try and fix this.
Reference:
Aside:
There may be a trick in javascript/p5 to resolve this, maybe to do with anti-aliasing?
I've tried adding a stroke to the shapes, but then we loose the clean corners between shapes.
The text was updated successfully, but these errors were encountered: