fix: SVG sanitization for file uploaded with 'sideload' action #2406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Codeinwp/otter-internals/issues/242
Summary
The sanitize function was already added for
wp_handle_upload_prefilter,
but the files uploaded via the WP rest endpoint for media triggered this filter.On closer inspection of the endpoint source code, instead of
upload
, it was using asideload
action. Thus, I also included it as a part of the filterwp_handle_sideload_prefilter
.Besides this, the filename will have a random suffix attached per recommendations.
Screenshots
Checklist before the final review