-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rock] Add PHP unit tests #1824
Conversation
Bundle Size Diff
|
Plugin build for beec0d9 is ready 🛎️!
|
E2E SummaryTyping
Values above 60ms"0 - 65.98, 2 - 94.53, 4 - 61.05, 5 - 65.74, 6 - 85.34, 7 - 97.19, 8 - 68.02, 9 - 76.16, 10 - 75.08, 11 - 87.75, 12 - 85.66, 13 - 71.82, 14 - 67.45, 15 - 77.95, 16 - 73.57, 17 - 64.44, 18 - 65.74" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the failing tests before putting it for review? Also, why do we have two separate unit tests actions?
I removed the old method. The old method was installing the test instance on the local machine. The new one will use a docker test instance provided by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've left a NIT but it looks good. We should get a good QA done on these features, Block Conditions in particular as I see there is some code change there to confirm that everything works just like before.
@Soare-Robert-Daniel Tested and everything's fine on my end 🚀 |
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1623
Summary
Added units tests for:
Locally the test can be run with Docker provided by Gutenberg packages.
Test instructions
Checklist before the final review