-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slider error on Block creation #1823
Conversation
Bundle Size Diff
|
Plugin build for 2ff1ae6 is ready 🛎️!
|
E2E SummaryTyping
Values above 60ms"0 - 86.84, 1 - 77.92, 2 - 87.18, 3 - 73.29, 4 - 90.76, 5 - 79.99, 6 - 86.64, 7 - 90.57, 8 - 92.19, 9 - 101.75, 10 - 84.65, 11 - 134.33, 12 - 81.77, 13 - 96.72, 14 - 94.85, 15 - 82.27, 16 - 78.58, 17 - 81.83, 18 - 88.59" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. During the testing, we can make sure to test it for backward compat & how it works in Widgets area and FSE.
@Soare-Robert-Daniel Tested and didn't find any problem 🚀 |
🎉 This PR is included in version 2.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1710
Summary
querySelector
. This is working nicely in FSE and Widgets. But I still need thequerySelector
to check if the root is reachable by Glide -- e.g.: Inserter Block Review is not reachable.Screenshots
2023-08-21.17-40-43.mp4
Test instructions
Checklist before the final review