Close codefire files when tab is closed (Fix #45)

CodeboxIDE · Nov 12, 2013 · da29187 · da29187
1 parent 34a3865
commit da29187
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 6 deletions.
diff --git a/addons/editor/addon-built.js b/addons/editor/addon-built.js
diff --git a/addons/editor/views/file.js b/addons/editor/views/file.js
@@ -45,6 +45,9 @@ define([
             this.parent.on("tab:state", function(state) {
                 if (state) this.editor.focus();
             }, this);
+            this.parent.on("tab:close", function() {
+                this.editor.sync.close();
+            }, this);
             this.editor.focus();
         },
 

diff --git a/client/utils/filesync.js b/client/utils/filesync.js
@@ -293,7 +293,7 @@ define([
             if (this.file != null) {
                 return this.file.codebox.socket("filesync");
             } else {
-                throw new Error("need 'file' to creat sync socket");
+                throw new Error("need 'file' to create sync socket");
             }
         },
 
@@ -600,7 +600,14 @@ define([
         sendSync: function() {
             this.send("sync");
             return true;
-        }
+        },
+
+        /*
+         *  Close the connexion
+         */
+        close: function() {
+            return this.send("close");
+        },
     });
 
     return FileSync;

diff --git a/core/cb.addons/addon.js b/core/cb.addons/addon.js
@@ -53,12 +53,12 @@ var Addon = function(logger, _rootPath) {
     };
 
     // Optimize the addon
-    this.optimizeClient = function() {
+    this.optimizeClient = function(force) {
         var that = this;
         var d = Q.defer();
 
         if (!this.isClientside()
-        || this.isOptmized()) {
+        || (this.isOptmized() && !force)) {
             return Q(this);
         }
 

diff --git a/core/cb.addons/main.js b/core/cb.addons/main.js
@@ -73,7 +73,7 @@ function setup(options, imports, register, app) {
         if (options.dev) {
             logger.log("Optmize defaults addons for production");
             first = first.then(runAddonsOperation(function(addon) {
-                return addon.optimizeClient();
+                return addon.optimizeClient(true);
             }));
         }