Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stack and minial config to setup on local #67

Closed
wants to merge 2 commits into from
Closed

add stack and minial config to setup on local #67

wants to merge 2 commits into from

Conversation

olarno
Copy link

@olarno olarno commented Apr 16, 2023

Issue

start changes README file.

@vassilidev vassilidev changed the base branch from master to develop April 16, 2023 19:24
@vassilidev vassilidev requested a review from geeksesi April 16, 2023 19:51
@vassilidev vassilidev added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Apr 16, 2023
@vassilidev vassilidev linked an issue Apr 16, 2023 that may be closed by this pull request

```
npm run build
php artisan config:cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ? do not do this things for development. it's for production.
in develop cache route, view,... could affect to your develop process.

```
```
php artisan server
INFO Server running on [http://127.0.0.1:8000].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not put the output here. people will copy this without knowing what it is 😅

php artisan migrate --force
```

> *TODO add dummies data ?*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have dummies data. yet.

```

## Installation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a section for .env
about how configure login as github.
about redis, horizon queues,

also it will be awesome if we mention about Sail, it's easy to use

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course we need another layer here.
I don't know Sail and Horizon (give me some time to explore these) 👍


# Code Review Pals
Code Review Pals is a community-driven platform for code review, designed to help developers learn from each other and improve their skills by providing a place to share their code and get feedback from peers.

Our goal is to encourage developers of all levels to submit their code for review and to foster a supportive and collaborative environment where senior developers can help juniors learn and grow. We believe that code review is a vital part of the software development process, and that it helps improve code quality, catch bugs and security issues, and share knowledge.

## Contribution

```json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this json is not pretty.
just use

- PHP >= 8.1 ( prefer 8.2 )
- Laravel >= 10
- node.js >=  17.4
- MySQL >= 8
- Redis > 7
- and other ...

@geeksesi
Copy link
Collaborator

Thank you for your contribution ❤️

## Contribution

```json
"license": "MIT",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk why json here ? just stack info can be good without this

php artisan migrate --force
```

> *TODO add dummies data ?*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove todo + add issue

php artisan optimize
```
```
php artisan server
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have sail too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • serve and no server

### Local server

```
npm run build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build in local ?


```
npm run build
php artisan config:cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php artisan optimize

@olarno olarno closed this May 7, 2023
@olarno
Copy link
Author

olarno commented May 7, 2023

#78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation
3 participants