-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stack and minial config to setup on local #67
add stack and minial config to setup on local #67
Conversation
|
||
``` | ||
npm run build | ||
php artisan config:cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ? do not do this things for development. it's for production.
in develop cache route, view,... could affect to your develop process.
``` | ||
``` | ||
php artisan server | ||
INFO Server running on [http://127.0.0.1:8000]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not put the output here. people will copy this without knowing what it is 😅
php artisan migrate --force | ||
``` | ||
|
||
> *TODO add dummies data ?* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have dummies data. yet.
``` | ||
|
||
## Installation | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a section for .env
about how configure login as github.
about redis, horizon queues,
also it will be awesome if we mention about Sail, it's easy to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course we need another layer here.
I don't know Sail and Horizon (give me some time to explore these) 👍
|
||
# Code Review Pals | ||
Code Review Pals is a community-driven platform for code review, designed to help developers learn from each other and improve their skills by providing a place to share their code and get feedback from peers. | ||
|
||
Our goal is to encourage developers of all levels to submit their code for review and to foster a supportive and collaborative environment where senior developers can help juniors learn and grow. We believe that code review is a vital part of the software development process, and that it helps improve code quality, catch bugs and security issues, and share knowledge. | ||
|
||
## Contribution | ||
|
||
```json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this json is not pretty.
just use
- PHP >= 8.1 ( prefer 8.2 )
- Laravel >= 10
- node.js >= 17.4
- MySQL >= 8
- Redis > 7
- and other ...
Thank you for your contribution ❤️ |
## Contribution | ||
|
||
```json | ||
"license": "MIT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk why json here ? just stack info can be good without this
php artisan migrate --force | ||
``` | ||
|
||
> *TODO add dummies data ?* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove todo + add issue
php artisan optimize | ||
``` | ||
``` | ||
php artisan server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have sail too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- serve and no server
### Local server | ||
|
||
``` | ||
npm run build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build in local ?
|
||
``` | ||
npm run build | ||
php artisan config:cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
php artisan optimize
Issue
start changes README file.