#M27. Add "Status" model to replace "Last LMS module" field with a Foreignkey. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravelTimN
approved these changes
Oct 12, 2021
| "model": "accounts.status", | ||
| "pk": 6, | ||
| "fields": { | ||
| "display_name": "Studying for a (between Project 4 & 5)", |
There was a problem hiding this comment.
Why is this the only fixture that states: Studying for a whereas the others all just say Studying?
| "model": "accounts.status", | ||
| "pk": 8, | ||
| "fields": { | ||
| "display_name": "Working as Developer 0-3 yrs", |
There was a problem hiding this comment.
I would make this 0-2 years, and then pk9 can stay 3-5 years so the 3rd year doesn't overlap.
accounts/fixtures/statuses.json
Outdated
| "display_order": 13 | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
EOF blank line missing
| {% endfor %} | ||
| </table> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
Outer div with class of table-responsive seems to have gone missing... was this intentional, and is it still responsive?
| <button class="btn btn-primary btn-sm float-right downloadTable" data-tableid="judgesTable">Export Judges Data to CSV</button> | ||
| </div> | ||
|
|
||
| <table class="table table-sm border-top-0" id="judgesTable"> |
There was a problem hiding this comment.
Same here... outer div with table-responsive is now missing... assuming this was intentional, and does it still respond well?
stefdworschak
force-pushed
the
new_lms_modules
branch
from
8dc853c to
1b26604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull request type
Related Issue
#230
Configuration instructions
Testing
All tests passing successfully.