Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Storage Account Attribute #29

Merged
merged 10 commits into from
Sep 21, 2024
Merged

Updating Storage Account Attribute #29

merged 10 commits into from
Sep 21, 2024

Conversation

hunter-capestany-cf
Copy link
Contributor

The enable_https_traffic_only property has been superseded by https_traffic_only_enabled and has been replaced in the code.

@hunter-capestany-cf hunter-capestany-cf self-assigned this Sep 9, 2024
@hunter-capestany-cf hunter-capestany-cf linked an issue Sep 9, 2024 that may be closed by this pull request
The enable_https_traffic_only property has been superseded by https_traffic_only_enabled #28
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV_AZURE_35 Ensure default network access rule for Storage Accounts is set to deny azurerm_storage_account.main FAILED
/main.tf CKV_AZURE_40 Ensure that the expiration date is set on all keys azurerm_key_vault_key.cmk FAILED
/main.tf CKV_AZURE_112 Ensure that key vault key is backed by HSM azurerm_key_vault_key.cmk FAILED
/main.tf CKV_TF_2 Ensure Terraform module sources use a tag with a version number diag FAILED
/main.tf CKV2_AZURE_38 Ensure soft-delete is enabled on Azure storage account azurerm_storage_account.main FAILED
/main.tf CKV2_AZURE_40 Ensure storage account is not configured with Shared Key authorization azurerm_storage_account.main FAILED
/main.tf CKV2_AZURE_41 Ensure storage account is configured with SAS expiration policy azurerm_storage_account.main FAILED

Please review the above report. ⚠️

@github-actions GitHub Actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV_TF_2 Ensure Terraform module sources use a tag with a version number diag FAILED
/main.tf CKV_AZURE_35 Ensure default network access rule for Storage Accounts is set to deny azurerm_storage_account.main FAILED
/main.tf CKV_AZURE_244 Avoid the use of local users for Azure Storage unless necessary azurerm_storage_account.main FAILED
/main.tf CKV_AZURE_40 Ensure that the expiration date is set on all keys azurerm_key_vault_key.cmk FAILED
/main.tf CKV_AZURE_112 Ensure that key vault key is backed by HSM azurerm_key_vault_key.cmk FAILED
/main.tf CKV2_AZURE_41 Ensure storage account is configured with SAS expiration policy azurerm_storage_account.main FAILED
/main.tf CKV2_AZURE_38 Ensure soft-delete is enabled on Azure storage account azurerm_storage_account.main FAILED
/main.tf CKV2_AZURE_40 Ensure storage account is not configured with Shared Key authorization azurerm_storage_account.main FAILED

Please review the above report. ⚠️

@github-actions GitHub Actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV_TF_2 Ensure Terraform module sources use a tag with a version number diag FAILED
/main.tf CKV_AZURE_35 Ensure default network access rule for Storage Accounts is set to deny azurerm_storage_account.main FAILED
/main.tf CKV_AZURE_244 Avoid the use of local users for Azure Storage unless necessary azurerm_storage_account.main FAILED
/main.tf CKV_AZURE_40 Ensure that the expiration date is set on all keys azurerm_key_vault_key.cmk FAILED
/main.tf CKV_AZURE_112 Ensure that key vault key is backed by HSM azurerm_key_vault_key.cmk FAILED
/main.tf CKV2_AZURE_41 Ensure storage account is configured with SAS expiration policy azurerm_storage_account.main FAILED
/main.tf CKV2_AZURE_38 Ensure soft-delete is enabled on Azure storage account azurerm_storage_account.main FAILED
/main.tf CKV2_AZURE_40 Ensure storage account is not configured with Shared Key authorization azurerm_storage_account.main FAILED

Please review the above report. ⚠️

@github-actions GitHub Actions
Copy link
Contributor

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

@github-actions GitHub Actions
Copy link
Contributor

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

@github-actions GitHub Actions
Copy link
Contributor

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

@github-actions GitHub Actions
Copy link
Contributor

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

@github-actions GitHub Actions
Copy link
Contributor

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

@douglas-f douglas-f merged commit 0e9370e into main Sep 21, 2024
5 checks passed
@douglas-f douglas-f deleted the attribute_updates branch September 21, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglas-f douglas-f douglas-f approved these changes

Assignees

@hunter-capestany-cf hunter-capestany-cf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The enable_https_traffic_only property has been superseded by https_traffic_only_enabled
2 participants
@hunter-capestany-cf @douglas-f