Output_maps #7
Merged
Output_maps #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
herman-wong-cf
commented
Feb 12, 2024
herman-wong-cf
commented
- Updates outputs to use "maps" insstead of "lists" since the resource uses "for_each". This makes it easier to access the correct secret by providing the key instead of guessing what index your secret is.
|
🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟 |
herman-wong-cf
requested review from
douglas-f,
kourosh-forti-hands and
ksnavely-cf
|
do we need to account for any downstream module impacts with this? |
If downstream modules used index references instead of keys, then yes. I'm not aware of any modules doing this. |
kourosh-forti-hands
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.