Sg module integration #7
Conversation
jordan-fry-cf
requested review from
mscribellito,
douglas-f,
BClev,
kourosh-forti-hands and
ksnavely-cf
|
Markdown Valid |
Checkov Scan Results 📖:
Please review the above report. |
|
Markdown Valid |
Checkov Scan Results 📖:
Please review the above report. |
|
Markdown Valid |
Checkov Scan Results 📖:
Please review the above report. |
|
Markdown Valid |
Checkov Scan Results 📖:
Please review the above report. |
|
Markdown Valid |
|
🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟 |
|
|
||
| # Prerequisites | ||
|
|
||
| Generate an EC2 key pair and place the pem key in this directory. Add the pem file to the tfvars file. To match the example tfvars file, run the following command in the terminal while in this directory: |
There was a problem hiding this comment.
the way this reads, it creates a vpc itself. vpc and networking should only be done in the networking module. this module should only networking info as vars
There was a problem hiding this comment.
so are you opting that we remove VPC completely from the example?
There was a problem hiding this comment.
@douglas-f you good to close this out?
|
Markdown Valid |
|
|
||
| # Prerequisites | ||
|
|
||
| Generate an EC2 key pair and place the pem key in this directory. Add the pem file to the tfvars file. To match the example tfvars file, run the following command in the terminal while in this directory: |
There was a problem hiding this comment.
so are you opting that we remove VPC completely from the example?
|
Markdown Valid |
…S-EC2 into sg-module-integration
|
Markdown Valid |
Rewrote EC2 module to use the AWS-ACE-SecurityGroup module