Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix_ssm_attachment #24

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Fix_ssm_attachment #24

merged 5 commits into from
Oct 2, 2024

Conversation

herman-wong-cf
Copy link
Contributor

Changes

  • Fixed (resource "aws_iam_role_policy_attachment" "ssm_role_policy_attach") count to use 1 or 0 as conditional instead of "length(var.iam_policies)" which would result in multiple attachments of the same policy.
  • Changed terraform-aws-securitygroup ref pointer to use a tag version instead of a hash.

@herman-wong-cf
Copy link
Contributor Author

Add additional conditional of "&& length(var.iam_policies) > 0" to aws_iam_role_policy_attachment.ssm_role_policy_attach "count" as Hunter reports this doesn't work properly on Cisco ASA (no additional IAM policies attached).

@az-kennedy az-kennedy merged commit a0317f2 into main Oct 2, 2024
@az-kennedy az-kennedy deleted the fix_ssm_attachment branch October 2, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants