Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove_volume_tags #20

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Remove_volume_tags #20

merged 8 commits into from
Mar 26, 2024

Conversation

herman-wong-cf
Copy link
Contributor

  • Set ebs_optimized to "true" according to Checkov recommendations.
  • Per Terraform docs for "aws_instance" resource, setting "volume_tags" when "aws_ebs_volume" is being used to also define tags will cause a perpetual diff when reapplying. volume_tags is removed to avoid this problem.

Copy link
Contributor

@az-kennedy az-kennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked though with team this is good with me. Will communicate to parties and create a new major release

@az-kennedy az-kennedy merged commit 5fffe73 into main Mar 26, 2024
@az-kennedy az-kennedy deleted the remove_volume_tags branch March 26, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants