-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial pull request template. It hasn't been tested yet. #11
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# Pull Request Checklist | ||
|
||
> Take your time to read through these, don't just click through them. Only check the boxes if they apply. | ||
|
||
## Admin | ||
<!--- Ensure --> | ||
- [ ] **Required:** I have read the [contributing guidelines](https://coalfire.atlassian.net/wiki/spaces/CEHOME/pages/2648440862/Pull+Request+Best+Practices) for submitting a PR. | ||
|
||
## Types of changes | ||
<!--- What types of changes does your code introduce? --> | ||
- [ ] :bug: Bug fix (non-breaking change which fixes an issue) | ||
- [ ] :sparkle: New feature (non-breaking change which adds functionality) | ||
- [ ] :collision: Breaking change (fix or feature that would cause existing functionality to change) | ||
|
||
## Testing | ||
- [ ] **Required:** I have tested the proposed changes to code (i.e. `packer build`, `terraform apply`), and they are working. | ||
- [ ] **Required:** All GitHub Actions ran successfully. If they didn't, I left a note in the description to address this. | ||
- [ ] **Optional:** I have already applied/deployed the changes in my environment. | ||
|
||
#### Please check where this code has been tested: | ||
- [ ] Locally | ||
- [ ] Customer Environment | ||
- [ ] Coalfire Sandbox Environment (AWS GovCloud, Azure Gov, GCP, etc.) | ||
|
||
## Documentation | ||
- [ ] **Optional, recommended:** I have updated ***`README.md`***. | ||
- [ ] **Optional, recommended:** I have updated documentation in ***Confluence/Organization's relevant Wiki***. | ||
- [ ] **Optional, recommended:** I left comments ***in-line in the code*** to help others understand the changes. | ||
|
||
## Tagging / Assigning | ||
- [ ] **Required:** I have tagged a ***Reviewer(s)***. | ||
- [ ] **Required:** I have tagged an ***Assignee(s)***. | ||
- [ ] **Optional:** I have tagged relevant stakeholders in a ***Comment***. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed because repos should have CODEOWNERS defined