Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial pull request template. It hasn't been tested yet. #11

Merged
merged 1 commit into from
Jun 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Pull Request Checklist

> Take your time to read through these, don't just click through them. Only check the boxes if they apply.

## Admin
<!--- Ensure -->
- [ ] **Required:** I have read the [contributing guidelines](https://coalfire.atlassian.net/wiki/spaces/CEHOME/pages/2648440862/Pull+Request+Best+Practices) for submitting a PR.

## Types of changes
<!--- What types of changes does your code introduce? -->
- [ ] :bug: Bug fix (non-breaking change which fixes an issue)
- [ ] :sparkle: New feature (non-breaking change which adds functionality)
- [ ] :collision: Breaking change (fix or feature that would cause existing functionality to change)

## Testing
- [ ] **Required:** I have tested the proposed changes to code (i.e. `packer build`, `terraform apply`), and they are working.
- [ ] **Required:** All GitHub Actions ran successfully. If they didn't, I left a note in the description to address this.
- [ ] **Optional:** I have already applied/deployed the changes in my environment.

#### Please check where this code has been tested:
- [ ] Locally
- [ ] Customer Environment
- [ ] Coalfire Sandbox Environment (AWS GovCloud, Azure Gov, GCP, etc.)

## Documentation
- [ ] **Optional, recommended:** I have updated ***`README.md`***.
- [ ] **Optional, recommended:** I have updated documentation in ***Confluence/Organization's relevant Wiki***.
- [ ] **Optional, recommended:** I left comments ***in-line in the code*** to help others understand the changes.

## Tagging / Assigning
- [ ] **Required:** I have tagged a ***Reviewer(s)***.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed because repos should have CODEOWNERS defined

- [ ] **Required:** I have tagged an ***Assignee(s)***.
- [ ] **Optional:** I have tagged relevant stakeholders in a ***Comment***.
Loading