coro: redesign how tasks complete and are cleaned up #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pointer to kernel timespec struct must stay alive
The previous design was flawed and would not work properly with nested tasks. Also added ability to detach tasks.
Cloudef
force-pushed
the
coro-refactor
branch
from
b4204f6 to
3882e44
Compare
|
I tested my "example code" from last Issue, still not working, the execution is still stopped indefinitely. |
|
@Bob-van Your example code seems to work with io_uring, but not with posix backend. Seems like it showcases a different issue. I'll investigate that as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous design was flawed and would not work properly with nested
tasks.
Also added ability to detach tasks.
Later, I want to add more tests and maybe see if the code can be cleaned up more.
Fixes #22