Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit support link #421

Merged
merged 4 commits into from
Dec 3, 2024
Merged

fix: edit support link #421

merged 4 commits into from
Dec 3, 2024

Conversation

davlgd
Copy link
Collaborator

@davlgd davlgd commented Nov 8, 2024

Describe your PR

The ticket center support link is now often used in the documentation. So I removed the email/email link previously used (except when it make sense).

I let you decide if we should do this or not. If not, I can edit the PR to use a different link or use always the email if you prefer.

@davlgd davlgd self-assigned this Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Deployment has finished 👁️👄👁️ Your app is available here

Copy link

github-actions bot commented Nov 8, 2024

🚀 You updated your review app. Check it here

Copy link
Member

@cnivolle cnivolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I've just request a little change on the rephrasing of one sentence.
EDIT: This comment does not belong to the right PR. My bad.

@cnivolle cnivolle self-requested a review November 8, 2024 14:58
cnivolle
cnivolle previously approved these changes Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

🚀 You updated your review app. Check it here

cnivolle
cnivolle previously approved these changes Nov 8, 2024
Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked the syntax on related parts, to add clarity. Feel free to commit the suggestions or to provide alternatives.

content/doc/account/ssh-keys-management.md Outdated Show resolved Hide resolved
content/doc/account/ssh-keys-management.md Outdated Show resolved Hide resolved
content/doc/administrate/database-migration.md Outdated Show resolved Hide resolved
content/doc/find-help/troubleshooting.md Outdated Show resolved Hide resolved
content/guides/pgpool.md Outdated Show resolved Hide resolved
content/guides/pgpool.md Outdated Show resolved Hide resolved
content/guides/pgpool.md Outdated Show resolved Hide resolved
@juliamrch juliamrch added the waiting Waiting from fixes or tests by submitter label Nov 12, 2024
@davlgd davlgd requested a review from a team November 20, 2024 16:21
cnivolle
cnivolle previously approved these changes Nov 26, 2024
Copy link

🚀 You updated your review app. Check it here

1 similar comment
Copy link

🚀 You updated your review app. Check it here

Copy link

github-actions bot commented Dec 2, 2024

🚀 You updated your review app. Check it here

@cnivolle cnivolle dismissed juliamrch’s stale review December 2, 2024 14:49

Suggestions applied.

Copy link

github-actions bot commented Dec 2, 2024

🚀 You updated your review app. Check it here

@cnivolle cnivolle merged commit f127e2d into main Dec 3, 2024
3 checks passed
@cnivolle cnivolle deleted the davlgd-fix-support branch December 3, 2024 10:43
Copy link

github-actions bot commented Dec 3, 2024

You closed this PR and deleted the review app 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Waiting from fixes or tests by submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants