Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make bad commands exit with 1 #733

Merged
merged 1 commit into from
May 23, 2024
Merged

chore: make bad commands exit with 1 #733

merged 1 commit into from
May 23, 2024

Conversation

pdesoyres-cc
Copy link
Collaborator

@pdesoyres-cc pdesoyres-cc commented Apr 23, 2024 •
edited
Loading

Fixes #590

  • wait for release of cliparse

@pdesoyres-cc pdesoyres-cc self-assigned this Apr 23, 2024
@pdesoyres-cc pdesoyres-cc requested a review from a team as a code owner April 23, 2024 15:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

🔎 A preview has been automatically published:

  • 🐧 linux f161b1505085a9db05f17aee2483937f641de0ee30094f5e9cebd5045e8d7bf4
  • 🍏 macos 68efb10aa06625bd5ff28c575f1df6c489d471b9d3d227a1b014c23c6318d456
  • 🪟 win 3796cbe9e068a5b13f0782ea01516f2dbf81cd0e480f73ae00369da4c50b1357

This preview will be deleted once this PR is closed.

aurrelhebert
aurrelhebert reviewed Apr 25, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@aurrelhebert
Copy link
Member

I have a run a couple of tests and LGTM, we do get an exit code of 1 any time an error occurs, and 0 otherwise.

hsablonniere
hsablonniere reviewed May 22, 2024
View reviewed changes
Copy link
Member

@hsablonniere hsablonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @pdesoyres-cc 👏 🎉

I tested the built version in various scenarios and it works (as in triggers and error 😛) perfectly

@hsablonniere hsablonniere merged commit 3bc836e into master May 23, 2024
6 checks passed
@hsablonniere hsablonniere deleted the exit-1 branch May 23, 2024 13:22
@github-actions GitHub Actions
Copy link

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsablonniere hsablonniere hsablonniere left review comments

@aurrelhebert aurrelhebert aurrelhebert approved these changes

Assignees

@pdesoyres-cc pdesoyres-cc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make bad commands exit with 1
3 participants
@pdesoyres-cc @aurrelhebert @hsablonniere