Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update sysinfo to 0.26.2 #806

Merged
merged 3 commits into from
Sep 16, 2022
Merged

deps: update sysinfo to 0.26.2 #806

merged 3 commits into from
Sep 16, 2022

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Sep 14, 2022

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

Update sysinfo to 0.26.2. This dependency update has some nice things in store for us:

  • MacOS M1 temperature support
  • Bevy of bug fixes

Issue

If applicable, what issue does this address?

Closes: #382

Testing

If relevant, please state how this was tested. All changes must be tested to work:

This must be tested on all three platforms! Additionally, we'll want to test on M1 and (if possible) x86 macOS.

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang changed the title Update sysinfo 0.26.2 deps: update sysinfo to 0.26.2 Sep 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Base: 23.66% // Head: 23.66% // No change to project coverage 👍

Coverage data is based on head (01cd3ea) compared to base (a427a9d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   23.66%   23.66%           
=======================================
  Files          60       60           
  Lines       13239    13239           
=======================================
  Hits         3133     3133           
  Misses      10106    10106           
Impacted Files Coverage Δ
src/app/data_harvester/processes.rs 0.00% <ø> (ø)
src/app/data_harvester/processes/linux.rs 19.83% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang force-pushed the update_sysinfo_0.26.2 branch 11 times, most recently from 01cd3ea to 4ba5e1b Compare September 15, 2022 23:09
This dependency update has some nice things in store for us:
- MacOS M1 temperature support
- Bevy of bug fixes
@ClementTsang ClementTsang marked this pull request as ready for review September 16, 2022 08:40
@ClementTsang ClementTsang merged commit c6c7fb3 into master Sep 16, 2022
@ClementTsang ClementTsang deleted the update_sysinfo_0.26.2 branch September 16, 2022 08:42
@ClementTsang ClementTsang mentioned this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS M1 support
2 participants