-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support default selection of average CPU graph #1353
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1353 +/- ##
==========================================
+ Coverage 31.93% 32.09% +0.15%
==========================================
Files 97 98 +1
Lines 17048 17113 +65
==========================================
+ Hits 5444 5492 +48
- Misses 11604 11621 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I see yet no handle, is this intended? |
Intended. Aiming to cut down on some of the command-line flags. That said I do need to update docs. |
Ah shit. I do think this update will not work for my use case then. |
I'm not removing any at the moment, but I would prefer to add new functionality behind configs unless it makes sense to add a corresponding command line arg. I used to have a matching config for every command arg and now I feel like the command line argument list is a bit of a mess. This also holds true in the opposite direction, in that I might add args but not a config option if it doesn't seem like it'll be useful. My personal understanding of an option like this is that it's something you generally would want set permanently... hence why I only made it a config file option. |
That said, if there is interest in having it as a command line argument, I'll take a look. |
The way I make this permanent, is via a command line option. I have an alias for starters, and not even touched the config file yet. It would be one more config file to maintain and keep up in my head. And I prefer to just have one alias line in my shell config, and thats it. Now removing already used command line arguments would also break the user flow (scripts, again aliases in configurations) for a minor improvement, imho. |
Major/minor versions are declared as breaking, so 🤷 - I'm not the Rust project that plans on supporting every decision I've made in the past with perfect backwards compatibility forever. I have changed options and command line args before so that ship has long since sailed. That said, as I mentioned above, I am not really planning on removing current command line arguments at the moment. The config managing thing also wouldn't really be an issue if I finally get time to land #159. There are also many options in bottom that you cannot currently manage outside of config fields, so if you plan on ever using those, then you would have to open the automatically generated config file. That said, both of these topics are beyond the point of this PR. As for something on-topic, I'll look at adding a corresponding command-line arg, I think I'm okay with it for this one if I reorganize a few things first. |
Should I create a new issue for it? |
It's fine, no need since I'll probably just do it tonight. |
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Issue
If applicable, what issue does this address?
Closes: #1350
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)