Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-584 Fix extensive logging from grpcio 1.65 by capping the requirement #191

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

nitinbhojwani
Copy link
Contributor

What

Fix the extensive logging caused by grpcio >= 1.65.0 by capping the requirement to <1.65.0.

Bug

This bug is being tracked in the Github issue grpc/grpc#37162
Once the issue is resolved, we can remove the cap on the grpcio requirement.

@nitinbhojwani nitinbhojwani force-pushed the DEVX-584-cap-grpcio-ver-1.64 branch from 2b87a1d to 36c9fdf Compare August 13, 2024 10:19
Copy link

@mogith-pn mogith-pn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM !

Copy link

@gglickstein gglickstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! It looks like grpcio 1.65.4 may have resolved the logging issues but I haven't used it extensively yet.

@nitinbhojwani nitinbhojwani merged commit 15b11f4 into master Aug 13, 2024
6 checks passed
@nitinbhojwani nitinbhojwani deleted the DEVX-584-cap-grpcio-ver-1.64 branch August 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants