Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search & datasets #8

Merged
merged 21 commits into from
May 2, 2024
Merged

feat: search & datasets #8

merged 21 commits into from
May 2, 2024

Conversation

DaniAkash
Copy link
Contributor

@DaniAkash DaniAkash commented Apr 23, 2024

This pull request includes changes to the project's dependencies, changes to how UUIDs are generated and handled, and significant additions to the src/client/dataset.ts, src/client/input.ts, and src/client/search.ts files.

The most important changes are:

Dependency changes:

  • package.json: Added new development dependencies for @types/async, @types/cli-progress, and @types/lodash. Also added new production dependencies for async, cli-progress, and lodash. Updated the versions of @grpc/grpc-js, @grpc/proto-loader, and clarifai-nodejs-grpc and replaced uuidv4 with uuid. [1] [2]

UUID generation and handling:

  • src/client/app.ts and src/client/input.ts: Changed the import of uuid to use v4 as uuid instead of uuid from uuidv4. [1] [2]

Additions to src/client/dataset.ts:

  • A new Dataset class was added with several methods for handling datasets, including creating and deleting versions, listing versions, and uploading data from a folder or a CSV file.

Additions to src/client/input.ts:

  • Several new methods were added to the Input class for handling inputs, including methods for bulk uploading, waiting for inputs, deleting failed inputs, and retrying uploads. [1] [2] [3] [4] [5]

Additions to src/client/search.ts:

  • Several new methods and properties were added to the Search class, including support for different search algorithms and metrics, and improved handling of queries and pagination. [1] [2] [3] [4] [5] [6] [7]

Copy link
Contributor

github-actions bot commented Apr 23, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 62.05%
⬆️ +11.41%
3953 / 6370
🔵 Statements 62.05%
⬆️ +11.41%
3953 / 6370
🔵 Functions 64.77%
⬆️ +18.40%
114 / 176
🔵 Branches 68.08%
⬆️ +9.69%
305 / 448
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/index.ts 100% 100% 100% 100%
src/client/app.ts 82.45% 59.57% 73.68% 82.45% 100-101, 104-109, 159, 204-205, 210-211, 215, 265-266, 268, 287-321, 338-372, 383-404, 407-408, 444-445, 486-487, 521-522, 547-550, 646-647, 714-715, 742-743, 765-766, 788-789, 801-814, 834-835
src/client/dataset.ts 40.45% 28.57% 33.33% 40.45% 44-45, 47-53, 62-92, 95-110, 113-135, 151-152, 162-167, 176-219
src/client/input.ts 51.84% 66.66% 45.83% 51.84% 157-158, 163-164, 169-170, 173, 177-181, 186-189, 198-200, 251-254, 259, 262, 294-342, 379-382, 475-498, 512-557, 572-684, 687-715, 718-756, 759-800, 810-811, 826-831, 844-876, 879-911, 914-946, 949-963, 966-999, 1002-1031, 1068, 1073-1076, 1124-1136, 1141-1146, 1211-1215, 1218-1219
src/client/search.ts 88.83% 76.36% 100% 88.83% 72-73, 76-79, 104-110, 133-139, 157-160, 169-170, 197-198, 244-245, 257-269
src/constants/dataset.ts 100% 100% 100% 100%
src/constants/search.ts 100% 100% 100% 100%
src/datasets/upload/base.ts 0% 0% 0% 0% 1-54
src/datasets/upload/features.ts 0% 0% 0% 0% 1-42
src/datasets/upload/image.ts 0% 0% 0% 0% 1-241
src/schema/search.ts 100% 100% 100% 100%
src/utils/misc.ts 67.74% 63.63% 66.66% 67.74% 17-18, 24-32, 50-51, 59-69, 79-80, 84-85, 87-88
src/utils/types.ts 0% 0% 0% 0% 1-26
Generated in workflow #26

Copy link
Contributor

@alexandros-megas alexandros-megas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some examples in the examples dir of how to use search/datasets?

src/client/dataset.ts Outdated Show resolved Hide resolved
src/client/dataset.ts Show resolved Hide resolved
src/datasets/upload/features.ts Show resolved Hide resolved
src/utils/misc.ts Outdated Show resolved Hide resolved
src/client/input.ts Outdated Show resolved Hide resolved
src/datasets/upload/image.ts Show resolved Hide resolved
src/client/input.ts Outdated Show resolved Hide resolved
src/utils/types.ts Outdated Show resolved Hide resolved
@DaniAkash DaniAkash merged commit 39cd278 into main May 2, 2024
5 checks passed
@DaniAkash DaniAkash deleted the dani/datasets branch May 2, 2024 17:43
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants