fix: addressed review comments

Clarifai · May 2, 2024 · fd1c824 · fd1c824
1 parent 2f732dc
commit fd1c824
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/src/client/input.ts b/src/client/input.ts
@@ -9,13 +9,12 @@ import {
   Input as GrpcInput,
   Image,
   Point,
-  Polygon,
   Region,
   RegionInfo,
   Text,
   Video,
 } from "clarifai-nodejs-grpc/proto/clarifai/api/resources_pb";
-import { AuthConfig } from "../utils/types";
+import { AuthConfig, Polygon } from "../utils/types";
 import { Lister } from "./lister";
 import { Buffer } from "buffer";
 import fs from "fs";
@@ -739,9 +738,9 @@ export class Input extends Lister {
   }: {
     inputId: string;
     label: string;
-    polygons: number[][][];
+    polygons: Polygon[];
   }): Annotation {
-    const polygonsSchema = z.array(z.array(z.array(z.number())));
+    const polygonsSchema = z.array(z.array(z.tuple([z.number(), z.number()])));
     try {
       polygonsSchema.parse(polygons);
     } catch {

diff --git a/src/datasets/upload/features.ts b/src/datasets/upload/features.ts
@@ -1,4 +1,5 @@
 import { JavaScriptValue } from "google-protobuf/google/protobuf/struct_pb";
+import { Polygon } from "../../utils/types";
 
 export interface TextFeatures {
   imagePath?: undefined;
@@ -33,7 +34,7 @@ export interface VisualDetectionFeatures {
 export interface VisualSegmentationFeatures {
   imagePath: string;
   labels: Array<string | number>;
-  polygons: Array<Array<Array<number>>>;
+  polygons: Polygon[];
   geoInfo?: [number, number];
   id?: number;
   metadata?: Record<string, JavaScriptValue>;

diff --git a/src/utils/misc.ts b/src/utils/misc.ts
@@ -71,7 +71,7 @@ export function mergeObjects(obj1: AuthConfig, obj2: AuthConfig): AuthConfig {
 export class BackoffIterator {
   private count: number;
 
-  constructor({ count = 0 }: { count?: number } = { count: 0 }) {
+  constructor({ count } = { count: 0 }) {
     this.count = count;
   }
 

diff --git a/src/utils/types.ts b/src/utils/types.ts
@@ -21,3 +21,6 @@ export type GrpcWithCallback<TRequest, TResponse> = (
 export type PaginationRequestParams<T extends Record<string, unknown>> =
   | Omit<Partial<T>, "userAppId" | "pageNo" | "perPage">
   | Record<string, never>;
+
+export type Point = [number, number];
+export type Polygon = Array<Point>;