Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error dialogue persisting between screens #3103

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

Treefire33
Copy link
Contributor

About The Pull Request

Fixes the error dialogue from persisting between screens.

Linked Issues

fixes: #3040

Proof of Testing

2024-12-02.18-14-51.mp4

Other

If this isn't the best UX-wise, I do have another solution in mind.

@Treefire33 Treefire33 changed the title Fix error dialogue presisting between screens Fix error dialogue persisting between screens Dec 3, 2024
@scribblecrumb
Copy link
Collaborator

A useful fix, however it would be better to just disable other buttons on the screen while the window is open.

Instead of killing the UI elements for the error box upon pressing a button, disable the functionality of the other buttons instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Buttons on main menu are clickable through error dialogue
2 participants