[BUGFIX] New cat moon event crashfix #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
There were two new cat events that listed "former_clancat_backstories" as the backstory choice for the new cat. The code did not support category listings, it only supported singular backstory names. I've added support for category listings, but I also changed the problem events to list specific backstory names, as the category "former_clancat_backstories" held backstories that would not have made sense for the events in question.
Linked Issues
fixes #3089
Proof of Testing
Used debug ensure setting to force one of the problem events
Event went through without crashing
New warrior, Heatherdaisy, was generated with an appropriate backstory
Changelog/Credits