next and previous cats now determined by class

[j-gynn]

About The Pull Request

Fixes #2671 by bringing its outdated ordering code to parity with the other ordering code. Stores the function within Cat to centralise it. Also optimises the code itself since it was very slow for what it was doing.

Linked Issues

Fixes #2671

Proof of Testing

2671.Bugfix.mp4

Changelog/Credits

Bugfix: cat order on sprite screen is consistent

[scribblecrumb]

Seems like the chosen sorting order (rank, age, EXP, ect.) isn't preserved when viewing cat pages other than profile (such as relationships, family tree, choosing pages, ect.), instead it defaults to the rank sorting order. Can't remember if it was preserved before, but either way it would be nice to see that fixed here.

[j-gynn]

It always uses ID for this... I think it might cause problems to keep track of the other but I haven't looked at the codebase to confirm

[j-gynn]

It always uses ID for this... I think it might cause problems to keep track of the other but I haven't looked at the codebase to confirm

Update: this isn't true, the code only defaults to ID if the list screen hasn't been opened this session. Otherwise, it uses the same list that list screen uses, in the same order

[scribblecrumb]

Ah, I see, the screens I was looking at were ones that you hadn't implemented the new system on to. Could you implement this on the other screens with next/prev cat buttons?

[j-gynn]

Which ones are missing? I replaced all the ones I could find but maybe I've been dumb and not done it right.

[scribblecrumb]

Relationships screen, family tree, Choose mate/mentor/adoption