Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Patrol Outcomes + Patrol Art #2718

Merged

Conversation

SnapshotManor
Copy link
Contributor

About The Pull Request

  • Adds two new outcomes for patrol ID "gen_bord_kittypet_friends_with_dog"
  • Adds one new patrol art for "gen_bord_kittypet_friends_with_dog"

Why This Is Good For ClanGen

I wanted to create art for Saema's recently added patrols, as well as add some of my own takes on outcomes.

Proof of Testing

1
2bloodthirsty

Changelog/Credits

  • Added two new patrol outcomes
  • Added one new patrol art

Added 2 new patrol outcomes as well as editing existing patrol outcomes for the patrol art I made.
Added 2 new patrol outcomes as well as editing existing patrol outcomes for the patrol art I made.
New patrol art
resources/dicts/patrols/general/border.json Show resolved Hide resolved
resources/dicts/patrols/general/border.json Outdated Show resolved Hide resolved
resources/dicts/patrols/general/border.json Outdated Show resolved Hide resolved
resources/dicts/patrols/general/border.json Outdated Show resolved Hide resolved
Forgot to edit the patrol art for the existing patrols when I made the previous changes
Copy link
Collaborator

@anjubatus anjubatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I have some changes that I'd like to see in the art you submitted. Most important being the head and ears of the cat being a bit odd shape, but I have some other minor adjustments too, including removing some unnecessary details from the dog's face.
Näyttökuva 2024-09-22 141554
Näyttökuva 2024-09-22 141609

resources/dicts/patrols/general/border.json Outdated Show resolved Hide resolved
resources/dicts/patrols/general/border.json Outdated Show resolved Hide resolved
@scribblecrumb
Copy link
Collaborator

image

Some notes on the dog (from Kori)

image

and a suggestion from Tiny, mostly just regarding the collar. It was also suggested that you might consider adding a tag or buckle to the cat collar, as well as consider giving the dog a collar to better visually connect the two.

As I'm sure you can tell, we're a bit strict on patrol art quality, but you're doing very well! Once we have these last few bits ironed out, I think we'll be good.

For Kori & Tiny!
@scribblecrumb
Copy link
Collaborator

You've got a failing json test! I'd suggest running the json through a json checker to see what's missing

No idea how it got messed up but! I fixed it! lol
@scribblecrumb
Copy link
Collaborator

image

One last bit of feedback from Anju

My apologies- I didn't even see the lines removed in your first request, totally missed it. Fixed now! c:
@scribblecrumb scribblecrumb merged commit b3150e5 into ClanGenOfficial:development Sep 23, 2024
7 checks passed
@SnapshotManor SnapshotManor deleted the 2NewPT-+-PTArt branch October 3, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants