Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1112 remove top-level connections, fix some import warnings #1113

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

gabrielwol
Copy link
Collaborator

@gabrielwol gabrielwol commented Dec 16, 2024

What this pull request accomplishes:

  • Removes top level database connections in 3 dags
  • schedule_interval -> schedule deprecation warning
  • fixes for many other Airflow deprecation warnings
  • adjust pytest to include warnings
    • I tried upgrading env_canada to latest version to remove a deprecation warning, and then it downgraded google provider to 8.3 (2022). I wasn't comfortable with this so I backtracked on failing on warnings, but the only one remaining is about an env_canada which is about 50 less than before!

Issue(s) this solves:

What, in particular, needs to reviewed:

What needs to be done by a sysadmin after this PR is merged

  • I checked out this branch in /data/airflow/data_scripts to test the many DAG changes, we should revert to master

@gabrielwol gabrielwol requested a review from chmnata December 16, 2024 17:09
@gabrielwol gabrielwol self-assigned this Dec 16, 2024
@gabrielwol gabrielwol linked an issue Dec 16, 2024 that may be closed by this pull request
@gabrielwol gabrielwol marked this pull request as draft December 17, 2024 16:44
@gabrielwol gabrielwol linked an issue Dec 17, 2024 that may be closed by this pull request
@gabrielwol gabrielwol force-pushed the 1112-airflow-remove-top-level-connection-retrievals-in-4-dags branch from 4c1cd29 to 4a63acc Compare December 17, 2024 20:56
@gabrielwol gabrielwol marked this pull request as ready for review December 17, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant