Dynamic step targets from workflow inputs #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ type WorkflowDefinition struct { | |||
|
|
|||
| // StepDefinition structure to handle workflow steps | |||
| type StepDefinition struct { | |||
| Target string `yaml:"target,omitempty" json:"target,omitempty"` | |||
| Target PropertyAssignment `yaml:"target,omitempty" json:"target,omitempty"` | |||
There was a problem hiding this comment.
Has the spec been updated to define Target as a PropertyAssignment?
Can you provide a link to the update spec where this was changed?
|
Updated the README.md file to explain why these changes were made. The fact that this change is backward compatible is also mentioned as well as the intention to eventually discuss this feature with the TOSCA spec owners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Step Defintion target to a Property Assignment allowing us to use the get_input property function to set the target value dynamically from either workflow or template inputs.