Windows: fix build issue with newer version of Rust #1306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahsnyder
force-pushed
the
windows-rust-defaultlib
branch
from
edbab7c to
02d0770
Compare
Newer versions of Rust appear to include '/defaultlib:msvcrt' in the list of native static libs when you run '--print=native-static-libs'. MSVC doesn't know what to do with this when passed as a linker dependency. Since msvcrt.lib is ALSO listed, the solution seems to be to strip this item from the list.
micahsnyder
force-pushed
the
windows-rust-defaultlib
branch
from
02d0770 to
ad2bb89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of Rust appear to include '/defaultlib:msvcrt' in the list of native static libs when you run '--print=native-static-libs'.
MSVC doesn't know what to do with this when passed as a linker dependency.
Since msvcrt.lib is ALSO listed, the solution seems to be to strip this item from the list.