cmake/FindRust.cmake: inherit RUSTFLAGS from the environment #1301
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @liushuyu this makes sense to me. Will test it soon as our internal CI system is working right. (everything seems to be broken right now, very frustrating!) |
liushuyu
force-pushed
the
respect-build-flags
branch
from
664fe8f to
bef8451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the
FindRust.cmakescript so theRUSTFLAGSset from the environment won't be overridden.This is needed because some downstream distributors (e.g. Linux distros) will need to append several Rust flags to get reproducible builds and/or make the project build on certain architectures.