Refactor and extend FindRust.cmake #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shutton looks like your PR branch was started from an older commit and conflicts with the FindRust.cmake from the latest in |
shutton
force-pushed
the
refactor-cmake-findrust
branch
from
0afeab5 to
862b1ef
Compare
|
Ha! You fixed it a literal second after I wrote that. Nice. |
micahsnyder
requested changes
Jan 23, 2024
shutton
force-pushed
the
refactor-cmake-findrust
branch
from
89a4530 to
d3f2a76
Compare
Export additional build context to Rust-based builds, and eliminate some of the duplicated logic when bulding a macOS univeral binary.
shutton
force-pushed
the
refactor-cmake-findrust
branch
from
d3f2a76 to
2df7d5c
Compare
micahsnyder
changed the base branch from
feature/integrate-clamav-sys
to
main
micahsnyder
changed the base branch from
main
to
feature/integrate-clamav-sys
micahsnyder
approved these changes
Jan 24, 2024
micahsnyder
merged commit 248717f
into
Cisco-Talos:feature/integrate-clamav-sys
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export additional build context to Rust-based builds, and eliminate some of the duplicated logic when bulding a macOS univeral binary.