Skip to content

Commit

Permalink
Fix link error with LLD 17
Browse files Browse the repository at this point in the history
Developers of FreeBSD base system are currently working to upgrade its
LLVM/Clang/LLDB/LLD to 17. As a part of it they tried building all
ports in FreeBSD ports collections to check if build of them succeeds
with LLVM/Clang/LLD 17. As a result there are some ports that fail to
be built with it and unfortunately `security/clamav` is one of
them. The build of it fails with link error as following.

```
  ld: error: version script assignment of 'CLAMAV_PRIVATE' to symbol 'cli_cvdunpack' failed: symbol not defined
  ld: error: version script assignment of 'CLAMAV_PRIVATE' to symbol 'cli_dbgmsg_internal' failed: symbol not defined
  ld: error: version script assignment of 'CLAMAV_PRIVATE' to symbol 'init_domainlist' failed: symbol not defined
  ld: error: version script assignment of 'CLAMAV_PRIVATE' to symbol 'init_whitelist' failed: symbol not defined
  ld: error: version script assignment of 'CLAMAV_PRIVATE' to symbol 'cli_parse_add' failed: symbol not defined
  ld: error: version script assignment of 'CLAMAV_PRIVATE' to symbol 'cli_bytecode_context_clear' failed: symbol not defined
  cc: error: linker command failed with exit code 1 (use -v to see invocation)
```

According to the investigation of ClamAV's source code,
`cli_cvdunpack` is a static function so it isn't visible to external
consumers. And other mentioned symbols aren't found anywhere. So fix
link error by removing all of them from linker version script.
  • Loading branch information
Yasuhiro Kimura authored and micahsnyder committed Oct 19, 2023
1 parent c543eb5 commit a467bcb
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions libclamav/libclamav.map
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ CLAMAV_PRIVATE {
cli_strlcat;
cli_strlcpy;
cli_strntoul;
cli_cvdunpack;
cli_regcomp;
cli_regexec;
cli_regfree;
Expand All @@ -112,7 +111,6 @@ CLAMAV_PRIVATE {
cli_ole2_extract;
cli_errmsg;
cli_debug_flag;
cli_dbgmsg_internal;
cli_vba_readdir;
cli_vba_inflate;
cli_ppt_vba_read;
Expand Down Expand Up @@ -161,8 +159,6 @@ CLAMAV_PRIVATE {
regex_list_match;
cli_hashset_destroy;
phishing_init;
init_domainlist;
init_whitelist;
phishing_done;
blobCreate;
blobAddData;
Expand All @@ -184,7 +180,6 @@ CLAMAV_PRIVATE {
cli_ac_free;
cli_ac_chklsig;
cli_sigopts_handler;
cli_parse_add;
cli_bm_init;
cli_bm_scanbuff;
cli_bm_free;
Expand Down Expand Up @@ -224,7 +219,7 @@ CLAMAV_PRIVATE {
cli_bytecode_context_setparam_ptr;
cli_bytecode_context_setfile;
cli_bytecode_context_getresult_int;
cli_bytecode_context_clear;

cli_bytecode_init;
cli_bytecode_done;
cli_bytecode_debug;
Expand Down

0 comments on commit a467bcb

Please sign in to comment.