Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lints): sized_box_for_whitespace and prefer_const_literals_to_create_immutables rules #158

Merged
merged 1 commit into from
Oct 11, 2021
Merged

fix(lints): sized_box_for_whitespace and prefer_const_literals_to_create_immutables rules #158

merged 1 commit into from
Oct 11, 2021

Conversation

Neha62-lit
Copy link
Contributor

Ref: #149

Fix lint rules:

  • sized_box_for_whitespace
  • prefer_const_literals_to_create_immutables

@Neha62-lit
Copy link
Contributor Author

Hey @manjotsidhu Review this PR!

manjotsidhu
manjotsidhu approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@manjotsidhu manjotsidhu merged commit 5dbd355 into CircuitVerse:master Oct 11, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1329178339

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 73.648%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/ib/builders/ib_interaction_builder.dart 0 1 0.0%
Totals Coverage Status
Change from base Build 1327828636: -0.006%
Covered Lines: 3840
Relevant Lines: 5214
💛 - Coveralls

@manjotsidhu manjotsidhu mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manjotsidhu manjotsidhu manjotsidhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neha62-lit @coveralls @manjotsidhu