Several bug fixes & enhancements #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: make the title bar's text look bigger/origin size after clicking on it; update: move projector's bottom bar to top; fix: 20% majority -> 20% of the number; fix: 已经有一个Console Lite实例在运行 on Windows caused by limited user privilege; fix: old yarn.lock cause yarn install 's failure (see yarnpkg/yarn#6312); fix: Minio.Client complaining secure option deprecated;
XieJiSS
commented
Feb 21, 2019
| @@ -21,6 +21,9 @@ function pack(cb, silent) { | |||
| /^\/Console-Lite-/, | |||
| ], // Ignores databases, files and artifacts | |||
| icon: path.join(__dirname, '../images/icon'), | |||
| win32metadata: { | |||
| 'requested-execution-level': 'requireAdministrator', | |||
XieJiSS
commented
Feb 21, 2019
| @@ -243,7 +243,7 @@ function checkForUpdate() { | |||
| return new Promise((resolve, reject) => { | |||
| if(!_mc) _mc = new Minio.Client({ | |||
| endPoint: 'store.bjmun.org', | |||
| secure: true, | |||
| useSSL: true, | |||
There was a problem hiding this comment.
secure option is deprecated:
Error: "secure" option deprecated, "useSSL" should be used instead
at new Client (/Users/jiejiss/Work/git/Console-Lite/node_modules/minio/dist/main/minio.js:113:53)
at Promise (/Users/jiejiss/Work/git/Console-Lite/util.js:244:20)
at ...Remote: Using built in environments in CI platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarnpkg/yarn#6312);fixes #19