[SECENG] Update dependencies and config #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated linter, test tool version * updated linter configuration * replace slices.Sort with sort.Slice * updated go deps
vallieres
force-pushed
the
SECENG_update-dependencies-config
branch
from
070ffdc to
2929dcd
Compare
vallieres
changed the title
moses-001
reviewed
Dec 2, 2024
cpa/tester/test.go
Outdated
| @@ -25,7 +25,8 @@ func (t Test) NamedCases() []NamedTest { | |||
| for name, test := range t.Cases { | |||
| result = append(result, NamedTest{name, test}) | |||
| } | |||
| slices.SortFunc(result, func(a, b NamedTest) bool { return a.Name < b.Name }) | |||
| sort.Slice(result, func(i, j int) bool { return result[i].Name < result[j].Name }) | |||
There was a problem hiding this comment.
there is actually a standard lib slices package now, https://pkg.go.dev/slices#SortFunc. We might want to just swap to that dependency? Then we wouldn't need to change this I think?
I suggest it only because of this snippet from the sort package doc:
Note: in many situations, the newer [slices.SortFunc](https://pkg.go.dev/slices#SortFunc) function is more ergonomic and runs faster.
There was a problem hiding this comment.
great, could you do the same in cpa/tester/runner.go?
danmux
reviewed
Dec 9, 2024
go.mod
Outdated
| github.com/open-policy-agent/opa v0.68.0 | ||
| github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 | ||
| github.com/stretchr/testify v1.9.0 | ||
| golang.org/x/exp v0.0.0-20240909161429-701f63a606c0 |
There was a problem hiding this comment.
wrt @moses-001 comment - I think if we replace the other usages we could avoid this import completely
danmux
approved these changes
Dec 9, 2024
okmoses
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Update dependencies mostly, but at the same time let's update the tooling used and Go version.
Changes