Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish v19.3.0. [release] #310

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Publish v19.3.0. [release] #310

merged 1 commit into from
Dec 20, 2022

Conversation

JalexChen
Copy link
Contributor

No description provided.

@JalexChen JalexChen marked this pull request as ready for review December 14, 2022 18:14
@JalexChen JalexChen requested review from a team as code owners December 14, 2022 18:14
@JalexChen JalexChen enabled auto-merge (squash) December 14, 2022 18:14
FelicianoTech
FelicianoTech suggested changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@FelicianoTech FelicianoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the current alias.

@Royston-Shufflebotham-i2
Copy link

Given that you're publishing aliases of '19.3.0', '19.3' and 'current', is there a reason you don't also publish a plain '19' alias?

See also #294.

@JalexChen
Copy link
Contributor Author

hey @Royston-Shufflebotham-i2 - the current tag is equivalent to the 19 alias you are asking about. the lts tag is equivalent to the 18 version series per the designations at nodejs.org

@JalexChen JalexChen merged commit 8f5e90f into main Dec 20, 2022
@JalexChen JalexChen deleted the release-v19.3.0 branch December 20, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelicianoTech FelicianoTech FelicianoTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JalexChen @Royston-Shufflebotham-i2 @FelicianoTech