Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from unzip to yauzl #385

Merged
merged 2 commits into from
Jun 22, 2016
Merged

Switch from unzip to yauzl #385

merged 2 commits into from
Jun 22, 2016

Conversation

gagern
Copy link
Member

@gagern gagern commented Jun 22, 2016

The node package “unzip” appears to be pretty much unmaintained, and it has problem with the more recent versions of node. The package “yauzl” (Yet Another UnZip Library) appears to be the most suitable replacement.

The node package “unzip” appears to be pretty much unmaintained, and it has
problem with the more recent versions of node.  The package “yauzl” (Yet
Another UnZip Library) appears to be the most suitable replacement.
This is useful since unzipping all of GWT can be pretty slow.
@kranich
Copy link
Member

kranich commented Jun 22, 2016

@gagern Thanks for fixing this.

@kranich kranich merged commit cb40261 into CindyJS:master Jun 22, 2016
@kranich
Copy link
Member

kranich commented Jun 22, 2016

@gagern I hope you considered this ready for review and merge. Maybe we should not assign pull requests before the pull request is ready for review. (The push after the assignment was a bit unexpected, but was included in my review.)

@gagern
Copy link
Member Author

gagern commented Jun 22, 2016

@kranich: Yes, this was ready. When I assign a reviewer, I mean that at that moment I consider the branch complete. Nevertheless, occasionally I think of some related stuff that would fit in nicely with the merge in question, and update the branch. If it doesn't arrive in time, that's no problem since I'd just open another request for that. If it got included in a merge without recieving due review, that would be a bit of bad luck, though, so perhaps I should make an effort to do this less often.

@gagern gagern deleted the yauzl branch July 4, 2016 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants