Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve grammar for reset password email #7173

Merged
merged 5 commits into from
Oct 5, 2024
Merged

improve grammar for reset password email #7173

merged 5 commits into from
Oct 5, 2024

Conversation

romdricks
Copy link
Contributor

@romdricks romdricks commented Sep 30, 2024 •
edited
Loading

Description & Issue number it closes

Grammar improvements.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@romdricks romdricks requested a review from a team as a code owner September 30, 2024 22:41
@romdricks romdricks requested review from respencer, DawoudIO, grayeul, DAcodedBEAT, MrClever and bigtigerku and removed request for a team September 30, 2024 22:41
@romdricks romdricks changed the title Reset password email improve grammar for reset password email Sep 30, 2024
DawoudIO
DawoudIO approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@DawoudIO DawoudIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but will merge after we fix the local files and poeditor so that translation is not lost

@DawoudIO DawoudIO merged commit 23b3f44 into ChurchCRM:master Oct 5, 2024
5 checks passed
@DawoudIO DawoudIO added this to the vNext - Feature (5.12.0) milestone Oct 5, 2024
@DawoudIO DawoudIO added the UI label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawoudIO DawoudIO DawoudIO approved these changes

@respencer respencer Awaiting requested review from respencer respencer is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@DAcodedBEAT DAcodedBEAT Awaiting requested review from DAcodedBEAT DAcodedBEAT is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

@bigtigerku bigtigerku Awaiting requested review from bigtigerku bigtigerku is a code owner automatically assigned from ChurchCRM/developers

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
5.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@romdricks @DawoudIO