Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos and inaccurate filenames #7160

Merged
merged 4 commits into from
Sep 21, 2024
Merged

fix typos and inaccurate filenames #7160

merged 4 commits into from
Sep 21, 2024

Conversation

DAcodedBEAT
Copy link
Contributor

No description provided.

@DAcodedBEAT DAcodedBEAT added Code Smell javascript Pull requests that update Javascript code php Pull requests that update Php code labels Sep 21, 2024
@DAcodedBEAT DAcodedBEAT requested a review from a team as a code owner September 21, 2024 05:23
@DAcodedBEAT DAcodedBEAT requested review from respencer, DawoudIO, grayeul and MrClever and removed request for a team September 21, 2024 05:23
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.10.1) milestone Sep 21, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 21, 2024
View reviewed changes
src/skin/js/PersonView.js Dismissed Show dismissed Hide dismissed
src/skin/js/PersonView.js
let htmlVal = "";
let eamilMD5 = emailData["emailMD5"];
for (list of emailData["list"]) {
let emailMD5 = emailData["emailMD5"];

Check failure

Code scanning / devskim

A weak or broken hash algorithm was detected. Error

Weak/Broken Hash Algorithm
src/skin/js/PersonView.js Dismissed Show dismissed Hide dismissed
@DAcodedBEAT DAcodedBEAT merged commit 45c5c7f into master Sep 21, 2024
7 of 8 checks passed
@DAcodedBEAT DAcodedBEAT deleted the typos branch September 21, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@respencer respencer Awaiting requested review from respencer respencer is a code owner automatically assigned from ChurchCRM/developers

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees
No one assigned
Labels
Code Smell javascript Pull requests that update Javascript code php Pull requests that update Php code
Projects
None yet
Milestone
5.11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@DAcodedBEAT