Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Family List Columns Configurable #7149

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Make Family List Columns Configurable #7149

merged 1 commit into from
Sep 19, 2024

Conversation

bigtigerku
Copy link
Contributor

Description & Issue number it closes

#7021

Screenshots (if appropriate)

Before

Screenshot 2024-09-17 at 9 30 05 AM

Config Change

Hide Cell Phone and Email
Screenshot 2024-09-17 at 10 00 22 AM

After

Screenshot 2024-09-17 at 10 00 43 AM

How to test the changes?

See the above screenshots

Click View Active Families after changing Admin/ Edit General Settings / People Setup / sFamilyListColumns

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bigtigerku bigtigerku requested a review from a team as a code owner September 18, 2024 02:26
@bigtigerku bigtigerku requested review from respencer, DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team September 18, 2024 02:26
@DAcodedBEAT DAcodedBEAT merged commit dfe9001 into ChurchCRM:master Sep 19, 2024
5 checks passed
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.10.1) milestone Sep 19, 2024
@DAcodedBEAT DAcodedBEAT added enhancement UI php Pull requests that update Php code labels Sep 19, 2024
@bigtigerku bigtigerku mentioned this pull request Sep 19, 2024
Merged
DAcodedBEAT added a commit that referenced this pull request Sep 19, 2024
@DAcodedBEAT
Make Family List Columns Configurable (#7152)
a0cfe6b 
Cherry pick of #7149
There was an issue in PR merge.
<img width="1298" alt="Screenshot 2024-09-19 at 11 55 55 AM"
src="https://github.com/user-attachments/assets/30e2f19b-2f81-4725-8f63-e8c308321c28">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@respencer respencer Awaiting requested review from respencer respencer is a code owner automatically assigned from ChurchCRM/developers

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@DAcodedBEAT DAcodedBEAT Awaiting requested review from DAcodedBEAT DAcodedBEAT is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees
No one assigned
Labels
enhancement php Pull requests that update Php code UI
Projects
None yet
Milestone
5.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bigtigerku @DAcodedBEAT