Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Person's Initial Format #7141

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

bigtigerku
Copy link
Contributor

Description & Issue number it closes

Person's Initial format should be configurable.

Screenshots (if appropriate)

Before
Screenshot 2024-09-10 at 5 11 01 PM

After
Screenshot 2024-09-10 at 5 11 24 PM

How to test the changes?

Change Config
Screenshot 2024-09-10 at 5 10 26 PM

Delete Photo
Screenshot 2024-09-10 at 5 11 15 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bigtigerku bigtigerku requested a review from a team as a code owner September 11, 2024 00:16
@bigtigerku bigtigerku requested review from respencer, DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team September 11, 2024 00:16
@@ -7,6 +7,8 @@
use ChurchCRM\Utils\LoggerUtils;
use ChurchCRM\Utils\MiscUtils;

const initialFormatOptionFI = 'FI';
Copy link
Contributor

@DAcodedBEAT DAcodedBEAT Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to rename this constant? I don't know what FI means

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maybe add FL as a const too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe even expand the strings FI and FL to full words so the translations can make more sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to similar as iPersonNameStyle and removed this const.

@bigtigerku bigtigerku force-pushed the master branch 4 times, most recently from e9d9aa8 to f4df471 Compare September 12, 2024 05:08
@DawoudIO
Copy link
Contributor

Need some basic integration tests please

@bigtigerku
Copy link
Contributor Author

Need some basic integration tests please

Any test idea?
If this initial generation has an issue, standard.person.new.spec.js will fail.

@DawoudIO
Copy link
Contributor

Maybe just in your test change the setting value and call the initial image url

@bigtigerku
Copy link
Contributor Author

Maybe just in your test change the setting value and call the initial image url

I added cypress/e2e/api/private/admin/private.admin.person.initial.style.setting.spec.js

@DawoudIO DawoudIO self-requested a review September 13, 2024 07:44
@DawoudIO DawoudIO added the UI label Sep 13, 2024
Copy link
Contributor

@DawoudIO DawoudIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the software and hope to see more contributions from you

@DawoudIO DawoudIO merged commit 13d5ad7 into ChurchCRM:master Sep 13, 2024
5 checks passed
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.10.1) milestone Sep 16, 2024
@DAcodedBEAT DAcodedBEAT added the php Pull requests that update Php code label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Users php Pull requests that update Php code UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants