-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable Person's Initial Format #7141
Conversation
src/ChurchCRM/dto/Photo.php
Outdated
@@ -7,6 +7,8 @@ | |||
use ChurchCRM\Utils\LoggerUtils; | |||
use ChurchCRM\Utils\MiscUtils; | |||
|
|||
const initialFormatOptionFI = 'FI'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to rename this constant? I don't know what FI means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also maybe add FL as a const too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe even expand the strings FI and FL to full words so the translations can make more sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to similar as iPersonNameStyle and removed this const.
e9d9aa8
to
f4df471
Compare
Need some basic integration tests please |
Any test idea? |
Maybe just in your test change the setting value and call the initial image url |
I added cypress/e2e/api/private/admin/private.admin.person.initial.style.setting.spec.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the software and hope to see more contributions from you
Description & Issue number it closes
Person's Initial format should be configurable.
Screenshots (if appropriate)
Before
After
How to test the changes?
Change Config
Delete Photo
Type of change
How Has This Been Tested?
Docker
Checklist: