Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start removal of extract function from codebase + fix report tests #6613

Merged
merged 12 commits into from
Nov 6, 2023
Merged

start removal of extract function from codebase + fix report tests #6613

merged 12 commits into from
Nov 6, 2023

Conversation

DAcodedBEAT
Copy link
Contributor

No description provided.

@DAcodedBEAT
Copy link
Contributor Author

@DawoudIO I figure you can merge this whenever you want - I'll try to find and fix more usages of extract later

@DAcodedBEAT DAcodedBEAT changed the title start removal of extract function from codebase start removal of extract function from codebase + fix report tests Nov 5, 2023
@DAcodedBEAT DAcodedBEAT requested a review from DawoudIO November 5, 2023 22:31
@DAcodedBEAT DAcodedBEAT added Feature: Reports Integration Testing Code Smell javascript Pull requests that update Javascript code php Pull requests that update Php code labels Nov 5, 2023
@DAcodedBEAT DAcodedBEAT marked this pull request as ready for review November 5, 2023 22:33
@DAcodedBEAT
Copy link
Contributor Author

@DawoudIO can you review and merge this? I fixed up the tests that you wrote up for the report generation :)

@DawoudIO DawoudIO added this to the 5.1.1 milestone Nov 6, 2023
@DawoudIO DawoudIO merged commit f667f86 into master Nov 6, 2023
1 check passed
@DawoudIO DawoudIO deleted the extract branch November 6, 2023 00:52
@DAcodedBEAT DAcodedBEAT mentioned this pull request Nov 6, 2023
Closed
@meichthys meichthys mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawoudIO DawoudIO DawoudIO approved these changes

Assignees
No one assigned
Labels
Code Smell Feature: Reports Integration Testing javascript Pull requests that update Javascript code php Pull requests that update Php code
Projects
None yet
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@DAcodedBEAT @DawoudIO