Update NewsLetterLabels.php

[javacorey]

What's this PR do?

Fixes the bug where newsletter labels print with the country even when residents of the United States

Screenshots (if appropriate)

What Issues does it Close?

Closes 5983

What are the relevant tickets?

#5983

Any background context you want to provide?

Where should the reviewer start?

How should this be manually tested?

create labels from /LettersAndLabels.php

How should the automated tests treat this?

Questions:

• Is there a related website / article to substantiate / explain this change?

  • Yes - Link:
  • [x ] No

• Does the development wiki need an update?

  • Yes - Link:
  • [x ] No

• Does the user documentation wiki need an update?

  • Yes - Link:
  • [ x] No

• Does this add new dependencies?

  • Yes
  • [x ] No

• Does this need to add new data to the demo database

  • Yes
  • [x ] No

[MrClever]

LGTM - set it free

[brianteeman]

And what if you are in France and have addresses for people in the USA

[MrClever]

Good point. I hadn't tested this previously, but here's what happens on my 4.4.5 test system (we're based in NSW Australia):

1. Create "Mr Test Tester" who happens to reside at the Apple campus un Cupertino (because it's an easy USA-based address to remember):

2. Generate a "People Directory" and check for any locale weirdness:

Yep - that's a bug. I've raised #5986 to capture it.