[feat] draw red in max ts path when perf

ChunelFeng · Jun 2, 2024 · ca4e1af · ca4e1af
1 parent 7e802bf
commit ca4e1af
Show file tree

Hide file tree

Showing 7 changed files with 52 additions and 4 deletions.
diff --git a/src/GraphCtrl/GraphElement/GElement.cpp b/src/GraphCtrl/GraphElement/GElement.cpp
@@ -370,14 +370,20 @@ CVoid GElement::dump(std::ostream& oss) {
 CVoid GElement::dumpEdge(std::ostream& oss, GElementPtr src, GElementPtr dst, const std::string& label) {
     if (src->isGroup() && dst->isGroup()) {
         // 在group的逻辑中，添加 cluster_ 的信息
-        oss << 'p' << src << " -> p" << dst << label << "[ltail=cluster_p" << src << " lhead=cluster_p" << dst << "];\n";
+        oss << 'p' << src << " -> p" << dst << label << "[ltail=cluster_p" << src << " lhead=cluster_p" << dst << "]";
     } else if (src->isGroup() && !dst->isGroup()) {
-        oss << 'p' << src << " -> p" << dst << label << "[ltail=cluster_p" << src << "];\n";
+        oss << 'p' << src << " -> p" << dst << label << "[ltail=cluster_p" << src << "]";
     } else if (!src->isGroup() && dst->isGroup()) {
-        oss << 'p' << src << " -> p" << dst << label << "[lhead=cluster_p" << dst << "];\n";
+        oss << 'p' << src << " -> p" << dst << label << "[lhead=cluster_p" << dst << "]";
     } else {
-        oss << 'p' << src << " -> p" << dst << label << ";\n";
+        oss << 'p' << src << " -> p" << dst << label;
     }
+
+    if (src->perf_info_ && src->perf_info_->in_longest_path_
+        && dst->perf_info_ && dst->perf_info_->in_longest_path_) {
+        oss << "[color=red]";
+    }
+    oss << ";\n";
 }
 
 

diff --git a/src/GraphCtrl/GraphElement/GElementManager.h b/src/GraphCtrl/GraphElement/GElementManager.h
@@ -109,6 +109,7 @@ class GElementManager : public GElementObject,
     friend class GPipeline;
     friend class GRegion;
     friend class GMutable;
+    friend class GPerf;
     friend class UAllocator;
 };
 

diff --git a/src/GraphCtrl/GraphElement/_GEngine/GDynamicEngine/GDynamicEngine.cpp b/src/GraphCtrl/GraphElement/_GEngine/GDynamicEngine/GDynamicEngine.cpp
@@ -251,6 +251,7 @@ CVoid GDynamicEngine::parallelRunAll() {
 }
 #endif
 
+
 CVoid GDynamicEngine::serialRunAll() {
     /**
      * 如果分析出来 dag是一个链式的，则直接依次执行element

diff --git a/src/GraphCtrl/GraphElement/_GOptimizer/GOptimizer.h b/src/GraphCtrl/GraphElement/_GOptimizer/GOptimizer.h
@@ -53,6 +53,8 @@ class GOptimizer : public GElementObject {
 
         return paths;
     }
+
+    friend class GPerf;
 };
 
 CGRAPH_NAMESPACE_END

diff --git a/src/GraphCtrl/GraphPipeline/_GPerf/GPerf.cpp b/src/GraphCtrl/GraphPipeline/_GPerf/GPerf.cpp
@@ -9,6 +9,7 @@
 #include "GPerf.h"
 #include "GPerfDefine.h"
 #include "../GPipeline.h"
+#include "../../GraphElement/_GOptimizer/GOptimizerInclude.h"
 
 CGRAPH_NAMESPACE_BEGIN
 
@@ -22,6 +23,9 @@ CStatus GPerf::perf(GPipelinePtr pipeline, std::ostream& oss) {
     status = pipeline->process();
     CGRAPH_FUNCTION_CHECK_STATUS
 
+    status = markLongestPath(pipeline);
+    CGRAPH_FUNCTION_CHECK_STATUS
+
     status = pipeline->dump(oss);
     CGRAPH_FUNCTION_CHECK_STATUS
 
@@ -49,6 +53,32 @@ CStatus GPerf::inject(GPipelinePtr pipeline) {
 }
 
 
+CStatus GPerf::markLongestPath(GPipelinePtr pipeline) {
+    CGRAPH_FUNCTION_BEGIN
+    CGRAPH_ASSERT_NOT_NULL(pipeline, pipeline->element_manager_)
+    GElementPtrArr longestPath;
+    CFMSec maxTs = 0.0;
+    auto paths = GOptimizer::collectPaths(pipeline->element_manager_->manager_elements_);
+    for (const auto& path : paths) {
+        CFMSec curTs = 0.0;
+        for (auto* element : path) {
+            CGRAPH_ASSERT_NOT_NULL(element)
+            curTs += element->perf_info_->accu_cost_ts_;
+        }
+        if (curTs >= maxTs) {
+            maxTs = curTs;
+            longestPath = path;
+        }
+    }
+
+    for (auto* element : longestPath) {
+        CGRAPH_ASSERT_NOT_NULL(element->perf_info_)
+        element->perf_info_->in_longest_path_ = true;
+    }
+    CGRAPH_FUNCTION_END
+}
+
+
 CStatus GPerf::recover(GPipelinePtr pipeline) {
     CGRAPH_FUNCTION_BEGIN
     CGRAPH_ASSERT_NOT_NULL(pipeline)

diff --git a/src/GraphCtrl/GraphPipeline/_GPerf/GPerf.h b/src/GraphCtrl/GraphPipeline/_GPerf/GPerf.h
@@ -33,6 +33,13 @@ class GPerf : public GraphObject {
      */
     static CStatus inject(GPipeline* pipeline);
 
+    /**
+     * 查询最长链路信息
+     * @param pipeline
+     * @return
+     */
+    static CStatus markLongestPath(GPipeline* pipeline);
+
     /**
      * 恢复原来的pipeline信息
      * @param pipeline

diff --git a/src/GraphCtrl/GraphPipeline/_GPerf/GPerfDefine.h b/src/GraphCtrl/GraphPipeline/_GPerf/GPerfDefine.h
@@ -18,6 +18,7 @@ struct GPerfInfo : public CStruct {
     CFMSec first_start_ts_ = 0.0;          // 开始的时间戳
     CFMSec last_finish_ts_ = 0.0;          // 最后一次结束的时间（需要考虑多次执行，或者多次被循环执行的情况）
     CFMSec accu_cost_ts_ = 0.0;            // 总体的耗时信息(累计值)
+    CBool in_longest_path_ = false;        // 是否在最长耗时链路上
 };
 
 using GPerfInfoPtr = GPerfInfo *;