Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar & Footer updated #739

Merged
merged 15 commits into from
Aug 10, 2024
Merged

Navbar & Footer updated #739

merged 15 commits into from
Aug 10, 2024

Conversation

hars-21
Copy link
Contributor

@hars-21 hars-21 commented Aug 9, 2024

PR Description 📜

Successfully Updated the navbar and footer.
common code for every page
rendered navbar and footer on every page
It includes recently added testimonial page

Fixes #681 #705


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.

## Add your screenshots(Optional) 📸

Screen Shot 2024-08-09 at 5 34 41 PM
Screen Shot 2024-08-09 at 5 34 47 PM
Screen Shot 2024-08-09 at 5 34 53 PM
Screen Shot 2024-08-09 at 5 50 52 PM



Thank you soo much for contributing to our repository 💗

@ayush-t02
Copy link
Collaborator

resolve conflicts

@hars-21
Copy link
Contributor Author

hars-21 commented Aug 9, 2024

@ayush-t02 Resolved!! Please review

@ayush-t02
Copy link
Collaborator

@hars-21 there are a lot of conflicts as of now

@hars-21 hars-21 reopened this Aug 10, 2024
@hars-21
Copy link
Contributor Author

hars-21 commented Aug 10, 2024

@ayush-t02 I have resolved the merge conflicts. Please review

@ayush-t02 ayush-t02 merged commit 960acb2 into ChromeGaming:main Aug 10, 2024
@hars-21
Copy link
Contributor Author

hars-21 commented Aug 10, 2024

Also, there are new issues regarding the same

@hars-21
Copy link
Contributor Author

hars-21 commented Aug 10, 2024

@ayush-t02 But you assigned level3 as 2 issues were addressed. Please can you assign me level3 as issue #705 was given level3 label

@ayush-t02
Copy link
Collaborator

Both issues go hand in hand, updating navbar and footer is essentially redundant because what can you change now?

And responsiveness is an inherent part of all the work you do as a web developer and shouldn't be considered a separate issue.

@hars-21
Copy link
Contributor Author

hars-21 commented Aug 10, 2024

Please, as issue was given level 3 that's why I asked for level 3.

@ayush-t02
Copy link
Collaborator

ayush-t02 commented Aug 10, 2024

Ok

@ayush-t02 ayush-t02 added level3 and removed level2 labels Aug 10, 2024
@hars-21
Copy link
Contributor Author

hars-21 commented Aug 10, 2024

Thanks!!!!

@hars-21 hars-21 deleted the navbar branch August 17, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Navbar not working in mobile view
2 participants