Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra call to check_mint #567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove extra call to check_mint #567

wants to merge 1 commit into from

Conversation

enriquefynn
Copy link
Member

Closes #560

@enriquefynn enriquefynn requested a review from ruuda May 12, 2022 18:34
ruuda
ruuda approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@ruuda ruuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I thought this was going to be super tricky to review, removing an authorization check, but it turns out it literally had the same check two lines above, so this is safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruuda ruuda ruuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process_withdraw duplicates check_mint check.
2 participants
@enriquefynn @ruuda