Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final UI Cleanup #64

Merged
merged 8 commits into from
May 12, 2024
Merged

Final UI Cleanup #64

merged 8 commits into from
May 12, 2024

Conversation

infinimineralex
Copy link
Contributor

No description provided.

@Younitea
Copy link
Contributor

I would say we likely don't need the favorite tab at this point, everything else looks fine

Younitea
Younitea requested changes May 12, 2024
View reviewed changes
Copy link
Contributor

@Younitea Younitea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good, up to you on keeping favs in, but I think Delete Books Hook should likely still have a message, even if it is just book removed

Younitea
Younitea approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@Younitea Younitea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Younitea Younitea merged commit a95f691 into main May 12, 2024
2 checks passed
@infinimineralex infinimineralex deleted the cleanup branch May 12, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Younitea Younitea Younitea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infinimineralex @Younitea